Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-16297

[R] Improve detection of ARROW_*_URL variables for offline build

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 7.0.0
    • 9.0.0
    • R
    • *nix offline builds

    Description

      As npr mentioned in https://github.com/apache/arrow/pull/12849#issuecomment-1101489333, the current code in nixlibs.R doesn't handle components that have multiple words (because of the way it parses variable names from filenames). Until now, we've had a special case for the AWS variables, but ARROW_GOOGLE_CLOUD_CPP_URL and ARROW_NLOHMANN_JSON_URL also need handling. Instead of adding special cases, we can provide the correct ARROW_*_URL values with the new bash script added as part of ARROW-15092.

       

      I'll add a PR.

      Attachments

        Issue Links

          Activity

            People

              karldw Karl Dunkle Werner
              karldw Karl Dunkle Werner
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 10m
                  3h 10m