[ARROW-16158] [C++] rename ARROW_ENGINE to ARROW_SUBSTRAIT

• Type: Improvement
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 8.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/31565
• Assignee: Weston Pace
• Reporter: Jonathan Keane
• Created: 08/Apr/22 19:33
• Updated: 11/Jan/23 11:42
• Resolved: 24/Apr/22 16:15

Description

When we introduced substrait we reused the cmake + feature ARROW_ENGINE to mean compute+a few other things as well as the substrait consumer functionality. In general, right now, we don't yet need (or want) to build substrait in our packages (e.g. the R package) since many places don't yet take advantage of it. But the naming of the cmake or feature is now confusing: it effectively is only substrait if you separately enable compute, etc. but it makes it sound like the query engine we have been building since 6.0.0 is disabled.

We should rename ARROW_ENGINE to ARROW_SUBSTRAIT now and then we can add an ARROW_ENGINE later if we need to encompass a larger set of engine functionality (e.g. compute+spillover+scheduler+memory limits) if that's needed.

Issue Links

• links to: GitHub Pull Request #12915