[ARROW-15511] [Python] GIL not held for Ndarray1DIndexer on

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.0.1
• Fix Version/s: 7.0.2, 8.0.0
• Component/s: Python
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/30984
• Assignee: Micah Kornfield
• Reporter: Micah Kornfield
• Created: 31/Jan/22 21:55
• Updated: 11/Jan/23 11:37
• Resolved: 02/Feb/22 11:26

Description

In _ndarray_to_array the call to NdarrayToArrow in explicitly excluded from the GIL.  In some code-paths Ndarray1DIndexer is instantiated which will try to do PyINC_REF and PyDdecREf on initialization and destruction.  These code paths do not appear to acquire the GIL.

 

I'm not sure what the best fix is:

1. Acquire GIL as part of Ndarray1DIndexer construction.
2. Eliminate the nogil block in _ndarray_to_array
3. Eliminate the incref and decref calls in Ndarray1DIndexer
4. Something else?

Issue Links

• links to: GitHub Pull Request #12314