[ARROW-14769] [Go] Errors from MessageReader.Message don't get surfaced by Reader.Read

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: Go
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/30304
• Assignee: David Li
• Reporter: David Li
• Created: 18/Nov/21 14:26
• Updated: 11/Jan/23 08:42
• Resolved: 24/Nov/21 14:20

Description

Noticed while playing with a Flight client. This snippet inadvertently suppresses all errors that come from the underlying MessageReader since next sets done after an error is encountered.

func (r *Reader) Read() (array.Record, error) {
	if r.rec != nil {
		r.rec.Release()
		r.rec = nil
	}

	if !r.next() {
                // r.done is set if next() errors, so we always
                // return EOF instead of the actual error
		if r.done {
			return nil, io.EOF
		}
		return nil, r.err
	}

	return r.rec, nil
}

Issue Links

• links to: GitHub Pull Request #11739