Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-1467

[JAVA]: Fix reset() and allocateNew() in Nullable Value Vectors template

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.7.0
    • Java
    • None

    Description

      (1)

      allocateNew() in NullableValueVectors allocates extra memory for the validity vector of fixed-width vectors. Instead of doing bits.allocateNew(valueCount + 1), we should simply do bits.allocateNew(valueCount).

      AFAIK, the only case where we need an additional valueCount is for the offsetVector and we already do that. Additional valueCount for the validity vector is not needed.

      (2)

      reset() method should call reset() on the underlying value vector as well to re-initialize the state (allocation monitor, reader index etc) and zero out the buffers. Right now we just reset the validity vector.

      Attachments

        Activity

          People

            siddteotia Siddharth Teotia
            siddteotia Siddharth Teotia
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: