[ARROW-14255] [Python] FlightClient.do_action is a generator instead of returning one.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0.0
• Fix Version/s: 6.0.0
• Component/s: Python
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/29832
• Assignee: Alessandro Molina
• Reporter: Alessandro Molina
• Created: 07/Oct/21 14:13
• Updated: 11/Jan/23 08:38
• Resolved: 14/Oct/21 08:42

Description

According to the documentation ( https://arrow.apache.org/docs/python/generated/pyarrow.flight.FlightClient.html#pyarrow.flight.FlightClient.do_action ) I would expect to be able to invoke client.do_action and get back an iterator. While it seems that the function is in fact a generator itself.

This makes a big difference because if it returns an iterator I expect to be able to do client.do_action(...) and just ignore the result if I don't care. But if it's a generator ignoring the results makes so that it actually doesn't get invoked at all and thus that the server won't do anything.

It would make sense to make do_action return a generator instead of being a generator itself, that would keep backward compatibility and would avoid puzzled users that don't see their code being invoked when they do client.do_action(...)

Issue Links

• links to: GitHub Pull Request #11354