Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-1401

[C++] Add extra debugging context to failures in RETURN_NOT_OK in debug builds

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: C++
    • Labels:
      None

      Description

      This should show

      • the statement that failed
      • the file and line number

      I implemented this for CUDA failures in https://github.com/apache/arrow/pull/985 and I really like it. If we add glog to our toolchain we may be able to get full stack traces on failures.

      It would probably increase code size to much in release builds, so it should be a DEBUG only feature.

        Attachments

          Activity

            People

            • Assignee:
              wesmckinn Wes McKinney
              Reporter:
              wesmckinn Wes McKinney
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: