Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-13978

[C++] Bump gtest to 1.11 to unbreak builds with recent clang

    XMLWordPrintableJSON

Details

    • Test
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 6.0.0
    • C++

    Description

      Recent clang (like clang-14) fails to build the bundled google test. Excerpt:

      /arrow/build_01/googletest_ep-prefix/src/googletest_ep/googlemock/include/gmock/gmock-matchers.h:1506:3: error: definition of implicit copy constructor for 'FloatingEqMatcher<float>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
      GTEST_DISALLOW_ASSIGN_(FloatingEqMatcher);
      ^

      This was fixed in https://github.com/google/googletest/commit/1b066f4edfd5f84beed1bb164bd3816a6d7158fe, which is included in 1.11

      Thus, bump the bundled version to 1.11

      Attachments

        Issue Links

          Activity

            People

              apitrou Antoine Pitrou
              MarcoFalke Marco Falke
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 50m
                  2h 50m