[ARROW-13937] [C++][Compute] Add explicit output values to sign function and fix unary type checks

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 6.0.0
• Component/s: C++
• Labels: kernel pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/29547
• Assignee: Eduardo Ponce
• Reporter: Eduardo Ponce
• Created: 08/Sep/21 18:05
• Updated: 11/Jan/23 08:36
• Resolved: 13/Sep/21 14:05

Description

The sign function implementation for unsigned integers returns the result of a boolean expression because when casted to an integer it corresponds to the expected value (0 or 1). To make the function more clear, we should be explicit with the return values similar to the other sign kernels.

Issue Links

• is part of: ARROW-12861 [C++][Compute] Add sign function kernels
• links to: GitHub Pull Request #11113