Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-13500

[C++] warning: unrecognized command line option '-Wno-unknown-warning-option' when building with gcc 9.3

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 6.0.0
    • 6.0.0
    • C++

    Description

      Looks like this option isn't supported by gcc (it is supported by Clang) and only triggers when there's an existing warning, which we get due to getting some maybe uninitialized warnings. 

      /home/keith/git/arrow/cpp/src/arrow/tensor.cc: In member function 'arrow::Result<long int> arrow::Tensor::CountNonZero() const':
      /home/keith/git/arrow/cpp/src/arrow/tensor.cc:337:18: warning: '*((void*)& counter +8)' may be used uninitialized in this function [-Wmaybe-uninitialized]
       337 | NonZeroCounter counter(*this);
       | ^~~~~~~
      At global scope:
      cc1plus: warning: unrecognized command line option '-Wno-unknown-warning-option'
      

      These 2 lines likely just need to be deleted: https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L346-L347

      Attachments

        Issue Links

          Activity

            People

              keith.j.kraus Keith Kraus
              keith.j.kraus Keith Kraus
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m