[ARROW-13500] [C++] warning: unrecognized command line option '-Wno-unknown-warning-option' when building with gcc 9.3

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 6.0.0
• Fix Version/s: 6.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/18764
• Assignee: Keith Kraus
• Reporter: Keith Kraus
• Created: 29/Jul/21 23:02
• Updated: 11/Jan/23 08:33
• Resolved: 02/Aug/21 14:26

Description

Looks like this option isn't supported by gcc (it is supported by Clang) and only triggers when there's an existing warning, which we get due to getting some maybe uninitialized warnings. 

/home/keith/git/arrow/cpp/src/arrow/tensor.cc: In member function 'arrow::Result<long int> arrow::Tensor::CountNonZero() const':
/home/keith/git/arrow/cpp/src/arrow/tensor.cc:337:18: warning: '*((void*)& counter +8)' may be used uninitialized in this function [-Wmaybe-uninitialized]
 337 | NonZeroCounter counter(*this);
 | ^~~~~~~
At global scope:
cc1plus: warning: unrecognized command line option '-Wno-unknown-warning-option'

These 2 lines likely just need to be deleted: https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L346-L347

Issue Links

• links to: GitHub Pull Request #10834