Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-13451

[C++][Compute] Consider removing ScalarAggregateKernel

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • C++

    Description

      Scalar aggregation does not incur large memory overhead for the associated KernelState objects, so maybe it'd be acceptable to remove explicit scalar aggregation kernels in favor of reusing grouped aggregation kernels with a single group. This would decrease our maintenance burden significantly, and if the benchmarks don't show a regression for single-group aggregation then there's no reason not to.

      Even if there is a performance regression we could bundle the scalar and grouped aggregate kernels in the same compute::Function and decide between them in Dispatch*, rather than confusingly defining distinct "sum" and "hash_sum" functions

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              bkietz Ben Kietzman
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 10m
                  2h 10m