[ARROW-13315] [R] Wrap r_task_group includes with ARROW_R_WITH_ARROW checking

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 5.0.0
• Component/s: R
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/28991
• Assignee: Jonathan Keane
• Reporter: Jonathan Keane
• Created: 12/Jul/21 18:20
• Updated: 11/Jan/23 08:32
• Resolved: 15/Jul/21 12:23

Description

Need to wrap the includes with

#if defined(ARROW_R_WITH_ARROW)
...
#endif

at https://github.com/apache/arrow/blob/master/r/src/r_task_group.h#L20-L21

* installing *source* package ‘arrow’ ...
** using staged installation
*** Proceeding without C++ dependencies
------------------------- NOTE ---------------------------
See https://arrow.apache.org/docs/r/articles/install.html
for help installing Arrow C++ libraries
---------------------------------------------------------
** libs
g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG  -I'/usr/local/lib/R/site-library/cpp11/include'    -fpic  -g -O2 -fdebug-prefix-map=/build/r-base-tbZjLv/r-base-4.1.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic -c RTasks.cpp -o RTasks.o
g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG  -I'/usr/local/lib/R/site-library/cpp11/include'    -fpic  -g -O2 -fdebug-prefix-map=/build/r-base-tbZjLv/r-base-4.1.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic -c altrep.cpp -o altrep.o
In file included from RTasks.cpp:18:
./r_task_group.h:20:10: fatal error: arrow/util/parallel.h: No such file or directory
   20 | #include <arrow/util/parallel.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [/usr/lib/R/etc/Makeconf:177: RTasks.o] Error 1
make: *** Waiting for unfinished jobs....
ERROR: compilation failed for package ‘arrow’
* removing ‘/tmp/RtmpQLy29Z/Rinst325b11ebc1/arrow’

And also add a CI job that checks this

Issue Links

• links to: GitHub Pull Request #10707