Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-13315

[R] Wrap r_task_group includes with ARROW_R_WITH_ARROW checking

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.0
    • Component/s: R

      Description

      Need to wrap the includes with

      #if defined(ARROW_R_WITH_ARROW)
      ...
      #endif
      

      at https://github.com/apache/arrow/blob/master/r/src/r_task_group.h#L20-L21

      * installing *source* package ‘arrow’ ...
      ** using staged installation
      *** Proceeding without C++ dependencies
      ------------------------- NOTE ---------------------------
      See https://arrow.apache.org/docs/r/articles/install.html
      for help installing Arrow C++ libraries
      ---------------------------------------------------------
      ** libs
      g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG  -I'/usr/local/lib/R/site-library/cpp11/include'    -fpic  -g -O2 -fdebug-prefix-map=/build/r-base-tbZjLv/r-base-4.1.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic -c RTasks.cpp -o RTasks.o
      g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG  -I'/usr/local/lib/R/site-library/cpp11/include'    -fpic  -g -O2 -fdebug-prefix-map=/build/r-base-tbZjLv/r-base-4.1.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic -c altrep.cpp -o altrep.o
      In file included from RTasks.cpp:18:
      ./r_task_group.h:20:10: fatal error: arrow/util/parallel.h: No such file or directory
         20 | #include <arrow/util/parallel.h>
            |          ^~~~~~~~~~~~~~~~~~~~~~~
      compilation terminated.
      make: *** [/usr/lib/R/etc/Makeconf:177: RTasks.o] Error 1
      make: *** Waiting for unfinished jobs....
      ERROR: compilation failed for package ‘arrow’
      * removing ‘/tmp/RtmpQLy29Z/Rinst325b11ebc1/arrow’
      

      And also add a CI job that checks this

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jonkeane Jonathan Keane
                Reporter:
                jonkeane Jonathan Keane
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h