[ARROW-13104] [C++] ByteStreamSplit implementation uses invalid pointer cast

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/28808
• Assignee: Antoine Pitrou
• Reporter: Antoine Pitrou
• Created: 17/Jun/21 14:55
• Updated: 11/Jan/23 08:30
• Resolved: 30/Jun/21 09:12

Description

This code in src/parquet/encoding.cc:

template <>
void ByteStreamSplitEncoder<FloatType>::PutArrowArray(const ::arrow::Array& values) {
  DirectPutImpl<::arrow::FloatArray>(values,
                                     reinterpret_cast<::arrow::BufferBuilder*>(&values_));
}

template <>
void ByteStreamSplitEncoder<DoubleType>::PutArrowArray(const ::arrow::Array& values) {
  DirectPutImpl<::arrow::DoubleArray>(
      values, reinterpret_cast<::arrow::BufferBuilder*>(&values_));
}

Casts a TypedBufferBuilder<T>* to a BufferBuilder<T>*. Apparently it works by chance...

Issue Links

• links to: GitHub Pull Request #10596