[ARROW-12953] [C++][Compute] Refactor CheckScalar* to take Datum arguments

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.0.0
• Component/s: C++
• Labels: beginner pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/28675
• Assignee: Fernando Rodriguez
• Reporter: Ben Kietzman
• Created: 03/Jun/21 15:30
• Updated: 11/Jan/23 08:29
• Resolved: 05/Aug/21 00:21

Description

CheckScalar*() are useful functions, but expressing all permutations of input shape in the public signature is overkill. We should consolidate these from

// Scalar - Scalar
void CheckScalarBinary(std::string func_name, std::shared_ptr<Scalar> left_input,
                       std::shared_ptr<Scalar> right_input,
                       std::shared_ptr<Scalar> expected,
                       const FunctionOptions* options = nullptr);

// Array - Array
void CheckScalarBinary(std::string func_name, std::shared_ptr<Array> left_input,
                       std::shared_ptr<Array> right_input,
                       std::shared_ptr<Array> expected,
                       const FunctionOptions* options = nullptr);

// Array-Scalar
// Scalar-Array
// ...

to

void CheckScalarBinary(std::string func_name, Datum left_input,
                       Datum right_input,
                       Datum expected,
                       const FunctionOptions* options = nullptr);

Issue Links

• links to: GitHub Pull Request #10878