[ARROW-12918] [C++] Build errors with Visual Studio 16.10.31321.278

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.1
• Fix Version/s: 5.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/28646
• Assignee: David Li
• Reporter: Ian Cook
• Created: 01/Jun/21 15:09
• Updated: 11/Jan/23 08:29
• Resolved: 01/Jun/21 18:15

Description

The test-build-vcpkg-win CI job uses the current windows-2019 GHA runner image, so it often catches build errors caused by Visual Studio/MSVC updates.

The Visual Studio version in this image was just updated from 16.9.31229.75 to 16.10.31321.278 and the MSVC runtime was updated from 14.28.29914 to 14.29.30037 as shown at https://github.com/actions/virtual-environments/pull/3452/files). This seems to have triggered a new error:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30037\include\xutility(1232,54): error C2794: 'reference': is not a member of any direct or indirect base class of 'std::iterator_traits<_Iter>' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\arrow-stl-test.vcxproj]
          with
          [
              _Iter=arrow::stl::ArrayIterator<arrow::BaseBinaryArray<arrow::BinaryType>,arrow::stl::detail::DefaultValueAccessor<arrow::BaseBinaryArray<arrow::BinaryType>>>
          ] 

Full log: https://github.com/ursacomputing/crossbow/runs/2716032508

Log from the same CI job just before this update, showing no errors: https://github.com/ursacomputing/crossbow/runs/2708195132

There are no apache/arrow commits or vcpkg port updates changes that would explain this error so I strongly suspect it was caused by the Visual Studio update.

Issue Links

• links to: GitHub Pull Request #10428