Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-1275

[C++] Default static library prefix for Snappy should be "_static"

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Component/s: C++
    • Labels:
      None

      Description

      Max Risuhin can you take a look at this? Currently this is hard-coded at

      https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L503

      but in the new conda-forge Windows package (https://anaconda.org/conda-forge/snappy/1.1.6/download/win-64/snappy-1.1.6-vc14_1.tar.bz2), it is snappy_static.lib, which is more consistent with the other packages. We should change our vendored SnappyCMakeLists.txt to use that name. Also, we should utilize the CMake configuration variable for the static library suffix

        Attachments

          Activity

            People

            • Assignee:
              Max Risuhin Max Risuhin
              Reporter:
              wesmckinn Wes McKinney
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: