Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-12736

[C++] Eliminate unnecessary copy in FieldPath::Get()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 5.0.0
    • C++

    Description

      FieldPath::Get() uses RecordBatch::column_data which returns a vector<shared_ptr<>> by value instead of by reference - so with wide schemas, we end up copying and then destroying a lot of shared_ptrs. When done in a tight loop - as with dataset projection - this is a major performance pessimization.

      Attachments

        Issue Links

          Activity

            People

              lidavidm David Li
              lidavidm David Li
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 17h 20m
                  17h 20m