[ARROW-11790] [Rust][DataFusion] Change plan builder signature to take Vec<Expr> rather than &[Expr]

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0
• Component/s: Rust - DataFusion
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/27641
• Assignee: Andrew Lamb
• Reporter: Andrew Lamb
• Created: 25/Feb/21 22:17
• Updated: 11/Jan/23 08:22
• Resolved: 25/Mar/21 10:57

Description

Another thing to do is to change the signagure of LogicalPlanBuilder
from taking slices of owned things &[Expr] to just taking Vec<Expr> entirely

The rationale is that at all callsites you need to have an owned vec and Datafusion is going to copy anyways, so it would better to allow the caller to give up ownership

Issue Links

• links to: GitHub Pull Request #9692
• links to: GitHub Pull Request #9703