Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-11689 [Rust][DataFusion] Reduce copies in DataFusion LogicalPlan and Expr creation
  3. ARROW-11790

[Rust][DataFusion] Change plan builder signature to take Vec<Expr> rather than &[Expr]

    XMLWordPrintableJSON

Details

    Description

      Another thing to do is to change the signagure of LogicalPlanBuilder
      from taking slices of owned things &[Expr] to just taking Vec<Expr> entirely

      The rationale is that at all callsites you need to have an owned vec and Datafusion is going to copy anyways, so it would better to allow the caller to give up ownership

      Attachments

        Activity

          People

            alamb Andrew Lamb
            alamb Andrew Lamb
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 6h
                6h