[ARROW-11777] [Rust] impl AsRef for StringBuilder/BinaryBuilder

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0
• Component/s: Rust
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/pull/9570
• Assignee: Unassigned
• Reporter: Max Meldrum
• Created: 25/Feb/21 07:16
• Updated: 25/Feb/21 18:21
• Resolved: 25/Feb/21 18:21

Description

The current implementation of Arrow forces the users to pass a reference to the append_value methods of StringBuilder/BinaryBuilder. Whereas it is passed by value for other types of builders.  This patch suggests adding impl AsRef<[u8]> rather than the current &[u8] parameter.

Some background for this issue: I have a Rust derive macro which converts the specified struct to Arrow data. This macro assumes everything is passed by value to Arrow, hence the dilemma. 

Issue Links

• links to: GitHub Pull Request #9570