Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-11777

[Rust] impl AsRef for StringBuilder/BinaryBuilder

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0
    • Component/s: Rust

      Description

      The current implementation of Arrow forces the users to pass a reference to the append_value methods of StringBuilder/BinaryBuilder. Whereas it is passed by value for other types of builders.  This patch suggests adding impl AsRef<[u8]> rather than the current &[u8] parameter.

      Some background for this issue: I have a Rust derive macro which converts the specified struct to Arrow data. This macro assumes everything is passed by value to Arrow, hence the dilemma. 

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                meldrum Max Meldrum
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h