[ARROW-11700] [R] Internationalize error handling in tidy eval

• Type: New Feature
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0
• Component/s: R
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/27561
• Assignee: Neal Richardson
• Reporter: Neal Richardson
• Created: 19/Feb/21 17:57
• Updated: 11/Jan/23 08:21
• Resolved: 22/Mar/21 18:15

Description

We have

  tryCatch(eval_tidy(expr, mask), error = function(e) {
    # Look for the cases where bad input was given, i.e. this would fail
    # in regular dplyr anyway, and let those raise those as errors;
    # else, for things not supported by Arrow return a "try-error",
    # which we'll handle differently
    msg <- conditionMessage(e)
    # TODO: internationalization?
    if (grepl("object '.*'.not.found", msg)) {
      stop(e)
    }
    if (grepl('could not find function ".*"', msg)) {
      stop(e)
    }
    invisible(structure(msg, class = "try-error", condition = e))
  })

and tests for this behavior, but the tests are skipped because they only match correctly in an English locale because these base R messages are translated.

We can generate these regular expressions dynamically by triggering the R errors on a known nonexistent object:

> tryCatch(X_____X, error = function(e) conditionMessage(e))
[1] "object 'X_____X' not found"
> tryCatch(X_____X(), error = function(e) conditionMessage(e))
[1] "could not find function \"X_____X\""
> sub("X_____X", ".*", tryCatch(X_____X, error = function(e) conditionMessage(e)))
[1] "object '.*' not found"

And this will respect i18n:

> Sys.setenv(LANGUAGE="FR_fr")
> sub("X_____X", ".*", tryCatch(X_____X, error = function(e) conditionMessage(e)))
[1] "objet '.*' introuvable"

Issue Links

• links to: GitHub Pull Request #9717