[ARROW-11675] [CI][C++] Resolve ctest failures on VS 2019 builds

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.0
• Component/s: C++, CI, Continuous Integration
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/27538
• Assignee: Antoine Pitrou
• Reporter: Ian Cook
• Created: 17/Feb/21 17:30
• Updated: 11/Jan/23 08:21
• Resolved: 29/Jun/21 15:02

Description

Running ctest on Windows after building the Arrow library with Visual Studio 2019, I regularly see these two tests fail:

• TestStatisticsSortOrder/0.MinMax
• TestStatistic.Int32Extremums

Logs look like this:

[ RUN      ] TestStatisticsSortOrder/0.MinMax
D:/a/crossbow/crossbow/arrow/cpp/src/parquet/statistics_test.cc(670): error: Expected equality of these values:
  stats_[i].min()
    Which is: "\0\0\0\0"
  cc_metadata->statistics()->EncodeMin()
    Which is: "\x3\0\0\0"
D:/a/crossbow/crossbow/arrow/cpp/src/parquet/statistics_test.cc(838): error: Expected: this->VerifyParquetStats() doesn't generate new fatal failures in the current thread.
  Actual: it does.
[  FAILED  ] TestStatisticsSortOrder/0.MinMax, where TypeParam = struct parquet::PhysicalType<1> (1 ms)

[ RUN      ] TestStatistic.Int32Extremums
D:/a/crossbow/crossbow/arrow/cpp/src/parquet/statistics_test.cc(900): error: Expected equality of these values:
  stats->min()
    Which is: -2147483648
  expected_min
    Which is: 0
[  FAILED  ] TestStatistic.Int32Extremums (0 ms)

This happened in the crossbow task test-build-vcpkg-win until I removed ctest from dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat to suppress it: https://github.com/ursacomputing/crossbow/actions?query=branch:actions-99-github-test-build-vcpkg-win

This also happened when I ran the release verification script dev/release/verify-release-candidate.bat on 4.0.0 RC4 using conda for dependencies.

Diagnose and resolve these failures.

Issue Links

• is depended upon by: ARROW-12515 [Dev][Wiki][Release] Fix and update Windows RC verify script
• relates to: ARROW-11340 [C++] Add vcpkg.json manifest to cpp project root
• links to: GitHub Pull Request #10583