[ARROW-11642] [C++] Incorrect preprocessor directive for Windows in JVM detection

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 4.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/27505
• Assignee: Markus Silberstein Hont
• Reporter: Markus Silberstein Hont
• Created: 16/Feb/21 08:45
• Updated: 11/Jan/23 08:21
• Resolved: 16/Feb/21 21:45

Description

In the HDFS connector library, there are per-platform preprocessor directives to determine which libjvm and libhdfs binaries to use for file operations. This is currently (3.0.0) failing due to an incorrect preprocessor directive for Windows. The code is referring to "__WIN32" while the properly defined variable should be "_WIN32" (see https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160)

Issue Links

• supercedes: ARROW-5236 [Python] hdfs.connect() is trying to load libjvm in windows
• links to: GitHub Pull Request #9505