[ARROW-1162] Transfer Between Empty Lists Should Not Invoke Callback

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.4.1
• Fix Version/s: 0.5.0
• Component/s: Java
• External issue URL: https://github.com/apache/arrow/issues/16825
• Assignee: Abdel Hakim Deneche
• Reporter: Sudheesh Katkam
• Created: 29/Jun/17 04:53
• Updated: 11/Jan/23 07:13
• Resolved: 29/Jun/17 15:22

Description

Here's the test that fails:

public class TestBufferOwnershipTransfer {

  //...

  private static class Pointer<T> {
    T value;
  }

  private static CallBack newTriggerCallback(final Pointer<Boolean> trigger) {
    trigger.value = false;
    return new CallBack() {
      @Override
      public void doWork() {
        trigger.value = true;
      }
    };
  }

  @Test
  public void emptyListTransferShouldNotTriggerSchemaChange() {
    final BufferAllocator allocator = new RootAllocator(Integer.MAX_VALUE);

    final Pointer<Boolean> trigger1 = new Pointer<>();
    final Pointer<Boolean> trigger2 = new Pointer<>();
    final ListVector v1 = new ListVector("v1", allocator,
            FieldType.nullable(ArrowType.Null.INSTANCE),
            newTriggerCallback(trigger1));
    final ListVector v2 = new ListVector("v2", allocator,
            FieldType.nullable(ArrowType.Null.INSTANCE),
            newTriggerCallback(trigger2));

    v1.makeTransferPair(v2).transfer();

    assertFalse(trigger1.value);
    assertFalse(trigger2.value); // fails
  }
}