[ARROW-10274] [Rust] arithmetic without SIMD does unnecesary copy

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Invalid
• Component/s: Rust
• External issue URL: https://github.com/apache/arrow/issues/26269
• Assignee: Unassigned
• Reporter: Ritchie
• Created: 11/Oct/20 05:26
• Updated: 11/Jan/23 08:12
• Resolved: 26/Apr/21 12:37

Description

The arithmetic kernels that don't use SIMD create a `vec` in memory and later copy that data into a Buffer. Maybe we could directly write the arithmetic result to a mutable buffer and prevent this redundant copy?

 

 

    let values = (0..left.len())
                .map(|i| op(left.value(i), right.value(i))) 
                .collect::<Vec<T::Native>>();
     
      
            let data = ArrayData::new(
          T::get_data_type(),
                left.len(),
                None,
                null_bit_buffer,
                0,
                vec![Buffer::from(values.to_byte_slice())],
                vec![],
            );