[ARIES-1365] ServiceState attribute notifications slow down startup/shutdown time considerably

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: jmx-core-1.1.3
• Fix Version/s: jmx-1.1.5
• Component/s: JMX
• Labels: performance shutdown startup

Environment

org.apache.felix.framework 5.0.1

• Assignee: David Bosschaert
• Reporter: Joel Richard
• Created: 05/Aug/15 09:18
• Updated: 25/Aug/15 12:37
• Resolved: 25/Aug/15 12:33

Description

Around 20% of the startup time of our Felix OSGI container is spent creating attribute notifications for changed services in ServiceState#getAttributeChangeNotification. This is so slow because for each notification it calls bundleContext.getAllServiceReferences to get all service ids.

Here a few suggestions how this could be improved:

• The ServiceState could maintain its own list of service ids which is updated according to the service events
• The ServiceState could implement the NotificationEmitter directly and be aware when there are any listeners (in our case, there are mostly none).
• Make it possible to disable the attribute change notifications with configuration property.