Maven Archetype
  1. Maven Archetype
  2. ARCHETYPE-306

archetypes downloaded are not downloaded with their poms

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Component/s: None
    • Labels:
      None

      Description

      the archetype artifacts in local repository that are downloaded by the plugin don't contain the archetype's pom file.
      that becomes a problem when one attempts to index the local repository (using maven-repository-indexer). For teh archetypes one doesn't get the name and description indexed (as these are taken from the pom).

      1. ARCHETYPE-306.patch
        16 kB
        Lóránt Pintér

        Issue Links

          Activity

          Milos Kleint created issue -
          Milos Kleint made changes -
          Field Original Value New Value
          Link This issue is related to MRM-128 [ MRM-128 ]
          Hervé Boutemy made changes -
          Project Maven Archetype [ 11095 ] Maven Archetype Bundles [ 12090 ]
          Key ARCHETYPE-48 MARCHETYPES-5
          Component/s Plugin [ 11867 ]
          Affects Version/s 1.0-alpha-4 [ 12410 ]
          Hervé Boutemy made changes -
          Key MARCHETYPES-5 ARCHETYPE-306
          Project Maven Archetype Bundles [ 12090 ] Maven Archetype [ 11095 ]
          Hervé Boutemy made changes -
          Fix Version/s 2.0-alpha-6 [ 14604 ]
          Hide
          Lóránt Pintér added a comment -

          Allows the DefaultDownloader to also download the POM file whenever an archetype is requested. Modified test cases to include basic POM files for everything.

          One curious thing I could not solve is this assertion in DefaultRepositoryCrawlerTest:

                  assertTrue (
                      ( 5 <= result.getArchetypes ().size () )
                      && ( result.getArchetypes ().size () >= 7 )
                  );
          

          This checks the size of the result twice, first to see if it is larger than or equal to 5, then if it is larger than or equal to 7. This failed for me all the time, so I changed it to the more logical:

                  assertTrue (
                      ( 5 <= result.getArchetypes ().size () )
                      && ( result.getArchetypes ().size () <= 7 )
                  );
          

          ...where the number of archetypes should be between 5..7. Was this a typo previously maybe?

          Show
          Lóránt Pintér added a comment - Allows the DefaultDownloader to also download the POM file whenever an archetype is requested. Modified test cases to include basic POM files for everything. One curious thing I could not solve is this assertion in DefaultRepositoryCrawlerTest: assertTrue ( ( 5 <= result.getArchetypes ().size () ) && ( result.getArchetypes ().size () >= 7 ) ); This checks the size of the result twice, first to see if it is larger than or equal to 5, then if it is larger than or equal to 7. This failed for me all the time, so I changed it to the more logical: assertTrue ( ( 5 <= result.getArchetypes ().size () ) && ( result.getArchetypes ().size () <= 7 ) ); ...where the number of archetypes should be between 5..7. Was this a typo previously maybe?
          Lóránt Pintér made changes -
          Attachment ARCHETYPE-306.patch [ 51354 ]
          Hide
          Hervé Boutemy added a comment -

          patch applied in r1001441
          yes, you found a typo in a unit test that is now fixed (on my computer, the test was not failing)

          thank you

          Show
          Hervé Boutemy added a comment - patch applied in r1001441 yes, you found a typo in a unit test that is now fixed (on my computer, the test was not failing) thank you
          Hervé Boutemy made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          Assignee Herve Boutemy [ hboutemy ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 09:05:55 UTC 2015 [ 1428224755734 ]
          Mark Thomas made changes -
          Workflow jira [ 12716525 ] Default workflow, editable Closed status [ 12748355 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 22:17:37 UTC 2015 [ 1428272257260 ]
          Mark Thomas made changes -
          Workflow jira [ 12954014 ] Default workflow, editable Closed status [ 12991169 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Closed Closed
          1518d 1h 18m 1 Hervé Boutemy 26/Sep/10 10:51

            People

            • Assignee:
              Hervé Boutemy
              Reporter:
              Milos Kleint
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development