[ARCHETYPE-270] RemoteCatalogArchetypeDataSource leaves open wagon connection when archetype catalog retrieval fails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0-alpha-5
• Assignee: Benjamin Bentmann
• Reporter: Dan
• Created: 20/Oct/09 18:35
• Updated: 07/Nov/09 12:50
• Resolved: 07/Nov/09 12:50

Description

If you have an archetype catalog entry with a bad url/archetype catalog file (the file isn't there), the RemoteArchetypeCatalogDataSource blows up when it tries to get the file over wagon. After it blows up, the wagon connection is not disconnected - as a result, there is an orphaned job in progress 'Updating indexes: 0%' (which is also badly named). The problem is on line 88:

wagon.connect( wagonRepository );

(get fails) >>>>>>> wagon.get( fileName , catalog );

wagon.disconnect();
return readCatalog( new FileReader( catalog ) );

I assume it should disconnect in the catch() block below