Maven Archetype
  1. Maven Archetype
  2. ARCHETYPE-110

Maven archetype overwrites parent information

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-alpha-5
    • Component/s: None
    • Labels:
      None

      Description

      When creating a new archetype that I want to use for my projects I ran into some trouble with the created/copied pom.xml.

      The archetype pom.xml (\src\main\resources\archetype-resources\pom.xml) looks like this:

       <project>
        <parent>
      		<groupId>group</groupId>
      		<artifactId>masterpom</artifactId>
      		<version>1.0</version>
        </parent>
        <modelVersion>4.0.0</modelVersion>
        <groupId>group</groupId>
        <artifactId>${artifactId}</artifactId>
        <version>1.0</version>
      </project>

      When I run my archetype it creates a pom.xml that looks like:

      <project>
        <parent>
        <artifactId>integration</artifactId>
          <groupId>group</groupId>
          <version>1.0</version>
        </parent>
        <modelVersion>4.0.0</modelVersion>
        <groupId>group</groupId>
        <artifactId>test</artifactId>
        <version>1.0</version>
      </project>
      

      Where "integration" is the name of the pom in the folder that I'm running mvn archetype:create from.
      Digging into the source we find in DefaultArchetype.java that processTemplate is indeed reading the parent pom and overwriting whatever was found in the original pom.xml.
      Is this really what we want to achieve? It should be possible to keep the parent-pom from the pom.xml in the archetype since it reduces the need for all developers to change their newly created pom.xml.

      processTemplates
       if ( parentModel != null )
              {
                  Parent parent = new Parent();
                  parent.setGroupId( parentModel.getGroupId() );
                  if ( parent.getGroupId() == null )
                  {
                      parent.setGroupId( parentModel.getParent().getGroupId() );
                  }
                  parent.setArtifactId( parentModel.getArtifactId() );
                  parent.setVersion( parentModel.getVersion() );
                  if ( parent.getVersion() == null )
                  {
                      parent.setVersion( parentModel.getParent().getVersion() );
                  }
                  generatedModel.setParent( parent );
      

      Two alternative solutions:

      • If the parent-pom is specified in the archetype-pom, don't replace it
      • A parameter that we can supply that will leave the archetype-pom parent setting untouched.

      I vote for solution number 1....

      1. ARCHETYPE-110.patch
        0.6 kB
        Jason Voegele

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Unassigned
              Reporter:
              Peter Liljenberg
            • Votes:
              4 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development