[AMQNET-831] Allow extra AckTypes when using IndividualAcknowledge

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Implemented
• Affects Version/s: AMQP-2.2.0
• Fix Version/s: AMQP-2.2.0
• Component/s: ActiveMQ, AMQP, NMS
• Labels: features pull-request-available

Environment

Tested with apache artemis (from the latest image on quay.io/artemiscloud/activemq-artemis-broker)

• External issue URL: https://github.com/apache/activemq-nms-amqp/pull/86
• External issue ID: 86

Language

C#

• Assignee: Krzysztof Porębski
• Reporter: Jef Willems
• Created: 16/Mar/23 12:49
• Updated: 08/Aug/23 11:28
• Resolved: 06/May/23 18:13

Description

I wrote a pull request to allow acknowledging messages with different AckType's

When using individual acknowledgement, the current setup only accepts MODIFIED_FAILED_UNDELIVERABLE as a negative ack, the pull request allows to use MODIFIED_FAILED, REJECTED as ack types. This way the client can automatically use broker redelivery configurations.

The client library also is more in line with the qpid-jms counterpart when implementing this change: https://github.com/apache/qpid-jms/blob/main/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java#L323

 

The pull request can be found here: https://github.com/apache/activemq-nms-amqp/pull/86