[AMQNET-631] extension methods missing in 1.8.0 e.g. SessionExtensions.GetDestination

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.8.0
• Component/s: NMS

Environment

Windows / .NET Framework 4.x

• Regression: Regression
• Assignee: Unassigned
• Reporter: Bruce Dodson
• Created: 02/Dec/19 19:11
• Updated: 04/Apr/20 05:22

Description

After updating NMS to 1.8.0 in my project, I am getting build errors indicating that the GetDestination method is not available on ISession.

This method is defined in the SessionExtensions class, but it is conditionally included only if the symbol MONO or NET_3_5 is defined.

This symbol must have been defined previously, but is now omitted as part of the cleanup that was done for 1.8.

Perhaps the extension methods could be defined for any supported version of .NET at this point, assuming .NET < 3.5 is no longer supported by the project at all?

The extension method simply delegates to SessionUtil.GetDestination, which is exposed to public as well, so to work around the issue for my immediate need I just called that directly. However, the extension methods should still be provided as before, rather than have a breaking change.

Issue Links

• links to: GitHub Pull Request #11