[AMQNET-465] SessionExecutor Stop() sets taskrunner to null and then tries to shut it down

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 1.6.2
• Component/s: NMS
• Assignee: Jim Gomes
• Reporter: Matt Lagrotte
• Created: 31/Dec/13 16:21
• Updated: 31/Dec/13 16:47
• Resolved: 31/Dec/13 16:24

Description

It appears that the Stop() method sets the taskRunner to null prior to Shutdown() which will cause a NullReferenceException which gets bubbled up and causes the stop to be incomplete.

Here is the code:

SessionExecutor.cs

public void Stop()
{
    if(messageQueue.Running)
    {
        messageQueue.Stop();
        TaskRunner taskRunner = this.taskRunner;

        if(taskRunner != null)
        {
            this.taskRunner = null;
            taskRunner.Shutdown();
        }
    }
}