[AMQNET-360] ActiveMQ client ResponseCorrelator doesn't handle ExceptionResponse commands correctly.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.0, 1.5.1, 1.5.2
• Fix Version/s: 1.6.0
• Component/s: ActiveMQ
• Assignee: Timothy A. Bish
• Reporter: Timothy A. Bish
• Created: 14/Dec/11 16:45
• Updated: 02/May/13 02:29
• Resolved: 15/Dec/11 00:22

Description

The current implementation of the ResponseCorrelator deals with exception responses by calling the transport exception listener as well as throwing an exception from the request methods instead of just returning the ExceptionResponse message and allowing the caller to deal with the error. This prevents the caller from being able to recover from non-critical messages as the ExceptionListener calls marks the transport as failed in the Connection when it needn't be. The correct operation should be for the ExceptionResponse to be propagated to the caller (Connection) and allow that to deal with the error.

This is needed so that cases like TransactionRollbackException's returned from Commit requests when a failover occurs and the State Tracker rolls back the transaction because its state is in doubt. This is not a critical error and the Connection should be allowed to continue after this. Other cases similar to this also exist.

Issue Links

• is depended upon by: AMQNET-362 ActiveMQ ConnectionStateTracker should rollback transactions that have a pending Commit when a Failover occurs.
• is depended upon by: AMQNET-363 ActiveMQ client should throw the InvalidClientIDException from CheckConnected when broker reports the Id as invalid.
• is depended upon by: AMQNET-361 ActiveMQ Client should attempt to create NMS exceptions for Broker ExceptionResponse commands that contains exceptions