[AMQ-977] Topic destination created for channel:// destination name

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.0
• Assignee: Unassigned
• Reporter: Edwin Park
• Created: 15/Oct/06 17:38
• Updated: 12/Jun/07 14:39
• Resolved: 12/Jun/07 14:39

Description

in activemq-web/src/main/java/org/apache/activemq/web/MessageServletSupport.java, the following method is used to create a JMS Topic or Queue Destination. However, note that the topic:// and channel:// blocks both set is_topic=true, so effectively those two blocks do exactly the same thing:

protected Destination getDestination(WebClient client, HttpServletRequest request, String destinationName) throws JMSException {

// TODO cache destinations ???

boolean is_topic=defaultTopicFlag;
if (destinationName.startsWith("topic://"))

{ is_topic=true; destinationName=destinationName.substring(8); }

else if (destinationName.startsWith("channel://"))

{ is_topic=true; destinationName=destinationName.substring(10); }

else
is_topic=isTopic(request);

if( destinationOptions!=null )

{ destinationName += "?" + destinationOptions; }

if (is_topic)

{ return client.getSession().createTopic(destinationName); }

else

{ return client.getSession().createQueue(destinationName); }

}