ActiveMQ
  1. ActiveMQ
  2. AMQ-977

Topic destination created for channel:// destination name

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.0
    • Component/s: None
    • Labels:
      None

      Description

      in activemq-web/src/main/java/org/apache/activemq/web/MessageServletSupport.java, the following method is used to create a JMS Topic or Queue Destination. However, note that the topic:// and channel:// blocks both set is_topic=true, so effectively those two blocks do exactly the same thing:

      protected Destination getDestination(WebClient client, HttpServletRequest request, String destinationName) throws JMSException {

      // TODO cache destinations ???

      boolean is_topic=defaultTopicFlag;
      if (destinationName.startsWith("topic://"))

      { is_topic=true; destinationName=destinationName.substring(8); }

      else if (destinationName.startsWith("channel://"))

      { is_topic=true; destinationName=destinationName.substring(10); }

      else
      is_topic=isTopic(request);

      if( destinationOptions!=null )

      { destinationName += "?" + destinationOptions; }

      if (is_topic)

      { return client.getSession().createTopic(destinationName); }

      else

      { return client.getSession().createQueue(destinationName); }

      }

        Activity

        Edwin Park created issue -
        Hide
        james strachan added a comment -

        Patch applied, many thanks!

        Show
        james strachan added a comment - Patch applied, many thanks!
        james strachan made changes -
        Field Original Value New Value
        Fix Version/s 5.0.0 [ 11712 ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Jeff Turner made changes -
        Project Import Fri Nov 26 22:32:02 EST 2010 [ 1290828722158 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        239d 21h 1 james strachan 12/Jun/07 15:39

          People

          • Assignee:
            Unassigned
            Reporter:
            Edwin Park
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development