[AMQ-8613] Improve performance of selectors with a big sequence of OR and AND logical expressions

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.17.1
• Fix Version/s: 5.18.0, 5.17.2
• Component/s: JMS client
• Assignee: Jean-Baptiste Onofré
• Reporter: Enrico Olivelli
• Created: 27/May/22 07:51
• Updated: 17/Aug/22 06:50
• Resolved: 17/Aug/22 05:47

Description

Currently when you create a selector with OR and ANDs the filter creates a huge stack trace.

This is because for each element in the OR and AND expression node we have to execute a method call.

This is happening because OR and AND expressions are treated as BinaryExpressions.

A very simple but effecting improvement is to not represent OR and AND expressions as binary expression but store the list of siblings expression in only one node.