[AMQ-8122] DataByteArrayInputStreamTest.testNonAscii() is faulty

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: KahaDB
• Assignee: Jean-Baptiste Onofré
• Reporter: Marcono1234
• Created: 14/Jan/21 22:55
• Updated: 15/Jan/21 06:27

Description

It appears the unit test DataByteArrayInputStreamTest.testNonAscii() is faulty:

1. It loops with while(Character.isDefined(test)), however the Unicode data has gaps, currently with Java 15 the first gap is the code point 888, Character.isDefined(888) == false.
   Therefore this test never tries any higher code points. Looping up to, including Character.MAX_CODE_POINT might be better.
2. Based on the comment next to the variable test, it appears the author wanted to test supplementary code points as well, however by casting them to char when creating the String, they are cutting off code points > \uFFFF. It should instead convert the code point to a String like this:

   // Java 11
   String toTest = Character.toString(test);
   // Java < 11
   String toTest = String.valueOf(Character.toChars(test));
   

Issue Links

• relates to: AMQ-1911 Kaha store can not retrieve messages with non ASCII charcaters