ActiveMQ
  1. ActiveMQ
  2. AMQ-752

fix the uberjar to tidy up the notice/license files to make it absolutely clear whats going on

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.1, 4.1.0
    • Component/s: None
    • Labels:
      None

      Description

      all the various LICENSEs need to be appended into a single LICENSE and the notices consolidated.

      Also we might want to...

      • the MANIFEST lacks a Implementation-Vendor-Id. not reported harmful but is
        in the spec. suggested value: org.apache.
      • the MANIFEST lacks a Specification-Version but has an
        Implementation-Version. suggested value 4.0.
      • better if the source extracts into a directory with a different name from
        the binary distribution. for example, incubator-activemq-src for the source
        and incubator-activemq for the binary (say.
      • i would prefer the binaries and distributions names to contain apache. for
        example apache-incubator-activemq.

        Activity

        Hide
        Hiram Chirino added a comment -

        Applied changes to 4.1 and partially to 4.0... I think changing the module name on a big fix release would be in bad form.

        Show
        Hiram Chirino added a comment - Applied changes to 4.1 and partially to 4.0... I think changing the module name on a big fix release would be in bad form.
        Hide
        Hiram Chirino added a comment -

        I updated the project name to apache-incubator-activemq so that distributions include the apache in it. Fixing the issues with the META-INF and the having the src distro extract to directory with -src on it, I think will involve getting some help from the maven team.

        Show
        Hiram Chirino added a comment - I updated the project name to apache-incubator-activemq so that distributions include the apache in it. Fixing the issues with the META-INF and the having the src distro extract to directory with -src on it, I think will involve getting some help from the maven team.
        Hide
        Hiram Chirino added a comment -

        I've changed the build so that NOTICE and LICENSE files do not overwrite one another anymore. Those files are moved
        the the META-INF/${jar-name/ directory before we extract the next jar into the uber jar. So it's now possible to look at the original LICENSE, DISCLAIMER,NOTICE, and COPYRIGHT files that were include in each jar of the uber jar.

        Please let me know if that's still does not meet the requirements.

        Show
        Hiram Chirino added a comment - I've changed the build so that NOTICE and LICENSE files do not overwrite one another anymore. Those files are moved the the META-INF/${jar-name/ directory before we extract the next jar into the uber jar. So it's now possible to look at the original LICENSE, DISCLAIMER,NOTICE, and COPYRIGHT files that were include in each jar of the uber jar. Please let me know if that's still does not meet the requirements.
        Hide
        Robert Burrell Donkin added a comment -

        Uber jar licensing seems like a thorny issue to me and probably one that's quite a bit bigger than just ActiveMQ. Once I find some time, I should raise this on legal, write up some documentation in the release and then talk to the maveneers. If I don't before you're next release, please feel free to kick me (gently).

        Show
        Robert Burrell Donkin added a comment - Uber jar licensing seems like a thorny issue to me and probably one that's quite a bit bigger than just ActiveMQ. Once I find some time, I should raise this on legal, write up some documentation in the release and then talk to the maveneers. If I don't before you're next release, please feel free to kick me (gently).

          People

          • Assignee:
            Unassigned
            Reporter:
            james strachan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development