[AMQ-7443] Prefetch warnings should include client IP information

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.15.12
• Fix Version/s: 5.16.1, 5.15.15, 5.17.0
• Component/s: Broker, Transport
• Assignee: Jean-Baptiste Onofré
• Reporter: Lionel Cons
• Created: 18/Mar/20 08:32
• Updated: 15/Jan/21 07:02
• Resolved: 14/Jan/21 05:07

Description

In ActiveMQ up to 5.15.12, prefetch warnings look like this:

2020-03-18 09:25:07,892 [ActiveMQ NIO Worker 7] WARN TopicSubscription - TopicSubscription: consumer=ID:foo.acme.com-7195-1584519807454-1:61:-1:1, destinations=1, dispatched=563, delivered=897, matched=564, discarded=0, prefetchExtension=0, usePrefetchExtension=true: has twice its prefetch limit pending, without an ack; it appears to be slow

This is not enough to find the culprit client (after the fact). ActiveMQ should (also) log the client IP address (and port). It should ideally be similar to other warnings like:

2020-03-18 09:18:31,539 [ActiveMQ InactivityMonitor Worker] WARN Transport - Transport Connection to: tcp://192.1.1.1:51550 failed: org.apache.activemq.transport.InactivityIOException: Channel was inactive for too (>7500) long: tcp://192.1.1.1:51550