[AMQ-7291] Message body is read-only exception when setting property on Bytes message

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.x
• Fix Version/s: 5.16.0
• Component/s: JMS client
• Assignee: Jean-Baptiste Onofré
• Reporter: Jorge Esteban Quilcate Otoya
• Created: 26/Aug/19 19:29
• Updated: 21/May/20 09:44
• Resolved: 21/May/20 09:44

Description

In Zipkin's Brave instrumentation for JMS clients, we are currently having issues on adding properties to ActiveMQ BytesMessage <https://github.com/openzipkin/brave/issues/967>

 

 While setting String property on `ActiveMQMessage` works fine, setting String property on `ActiveMQBytesMessage` throws "Message body is read-only exception".

 

Checking the source code `ActiveMQMessage` only checks if properties are read-only: https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/command/ActiveMQMessage.java#L493-L495

 

While `ActiveMQBytesMessage` check if body is read-only when setting property: https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/command/ActiveMQBytesMessage.java#L917 calling https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/command/ActiveMQBytesMessage.java#L834

 

Would love if someone can clarify if this is actually a bug and how to deal with this scenario if it is not.

 

Issue Links

• links to: GitHub Pull Request #420