[AMQ-7167] IP address is missing from TransportConnector error message

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.15.0
• Fix Version/s: 5.16.0
• Component/s: Transport
• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 13/Mar/19 10:19
• Updated: 13/Mar/19 10:26
• Resolved: 13/Mar/19 10:26

Description

When TLS errors out, the IP address is null in the acceptor error message which limits the value of the log message. This info can be stashed early to ensure it is available before the auto close

eg:

2019-03-11 13:24:27,639 [ActiveMQ BrokerService Task-14] ERROR TransportConnector - Could not accept connection from null: java.io.IOException: javax.net.ssl.SSLException: Inbound closed before receiving peer's close_notify: possible truncation attack?
2019-03-11 13:24:27,639 [ActiveMQ BrokerService Task-14] DEBUG TransportConnector - Reason: java.io.IOException: javax.net.ssl.SSLException: Inbound closed before receiving peer's close_notify: possible truncation attack?
java.io.IOException: javax.net.ssl.SSLException: Inbound closed before receiving peer's close_notify: possible truncation attack?
	at org.apache.activemq.transport.nio.NIOSSLTransport.initializeStreams(NIOSSLTransport.java:177)
	at org.apache.activemq.transport.stomp.StompNIOSSLTransport.initializeStreams(StompNIOSSLTransport.java:49)
	at org.apache.activemq.transport.tcp.TcpTransport.connect(TcpTransport.java:519)
	at org.apache.activemq.transport.nio.NIOTransport.doStart(NIOTransport.java:160)
	at org.apache.activemq.transport.nio.NIOSSLTransport.doStart(NIOSSLTransport.java:448)
	at org.apache.activemq.util.ServiceSupport.start(ServiceSupport.java:55)
	at org.apache.activemq.transport.TransportFilter.start(TransportFilter.java:58)
	at org.apache.activemq.transport.stomp.StompTransportFilter.start(StompTransportFilter.java:65)
	at org.apache.activemq.transport.AbstractInactivityMonitor.start(AbstractInactivityMonitor.java:169)
	at org.apache.activemq.transport.TransportFilter.start(TransportFilter.java:58)
	at org.apache.activemq.broker.TransportConnection.start(TransportConnection.java:1061)
	at org.apache.activemq.broker.TransportConnector$1$1.run(TransportConnector.java:218)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: javax.net.ssl.SSLException: Inbound closed before receiving peer's close_notify: possible truncation attack?
	at sun.security.ssl.Alerts.getSSLException(Alerts.java:208)
	at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1666)
	at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1634)
	at sun.security.ssl.SSLEngineImpl.closeInbound(SSLEngineImpl.java:1561)
	at org.apache.activemq.transport.nio.NIOSSLTransport.secureRead(NIOSSLTransport.java:359)
	at org.apache.activemq.transport.nio.NIOSSLTransport.doHandshake(NIOSSLTransport.java:406)
	at org.apache.activemq.transport.nio.NIOSSLTransport.initializeStreams(NIOSSLTransport.java:146)
	... 14 more