ActiveMQ
  1. ActiveMQ
  2. AMQ-705

ActiveMQActivationSpec does not validate that DestinationType is set to Topic when SubscriptionDurability is set to Durable

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.1, 3.2.2, 3.2.3, 4.0 M4, 4.0 RC2, 4.0 RC3
    • Fix Version/s: 3.2.4, 4.0
    • Component/s: JCA Container
    • Labels:
      None

      Description

      Found problem when using Geronimo with an incorrectly configured EJB 2.0 MDB that has:

      <message-driven-destination>
      <destination-type>javax.jms.Queue</destination-type>
      <subscription-durability>Durable</subscription-durability>
      </message-driven-destination>

      The above config doesn't make sense since subscription-durability is only applicable for Topics.

      This resulted in a message that didn't directly point to the problem:

      C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear myplan.xml
      Error: Unable to distribute my.ear: JMS settings for
      message-driven bean FooMDBean are not valid:
      Invalid settings: clientId must be set since durable subscription was requested. subscriptionName must be set since durable subscription was requested.

      With the patch applied, the error will now be:

      C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear wmyplan.xml
      Error: Unable to distribute my.ear: JMS settings for
      message-driven bean FooMDBean are not valid:
      Invalid settings: subscriptionDurability cannot be set to: Durable when destinationType is set to javax.jms.Queue as it is only valid when destinationType is set to javax.jms.Topic. clientId must be set since durable subscription was requested. subscriptionName must be set since durable subscription was requested.

      1. AMQ-705-incubator-trunk.patch
        3 kB
        John Sisson
      2. AMQ-705-activemq-3.patch
        3 kB
        John Sisson

        Activity

        John Sisson created issue -
        Hide
        John Sisson added a comment -

        Attached patch for review for activemq-3 branch.

        Show
        John Sisson added a comment - Attached patch for review for activemq-3 branch.
        John Sisson made changes -
        Field Original Value New Value
        Attachment AMQ-705-activemq-3.patch [ 14915 ]
        Hide
        John Sisson added a comment -

        Attached patch for review for incubator trunk.

        Show
        John Sisson added a comment - Attached patch for review for incubator trunk.
        John Sisson made changes -
        Attachment AMQ-705-incubator-trunk.patch [ 14916 ]
        John Sisson made changes -
        Description Found problem when using Geronimo with an incorrectly configured EJB 2.0 MDB that has:

                 <message-driven-destination>
                    <destination-type>javax.jms.Queue</destination-type>
                    <subscription-durability>Durable</subscription-durability>
                 </message-driven-destination>

        The above config doesn't make sense since subscription-durability is only applicable for Topics.

        This resulted in a message that didn't directly point to the problem:

        C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear myplan.xml
            Error: Unable to distribute my.ear: JMS settings for
            message-driven bean FooMDBean are not valid:
            Invalid settings: clientId must be set since durable subscription
            was requested. subscriptionName must be set since durable
            subscription was requested.

                Invalid settings: clientId must be set since durable subscription
            was requested. subscriptionName must be set since durable
            subscription was requested.
        Found problem when using Geronimo with an incorrectly configured EJB 2.0 MDB that has:

                 <message-driven-destination>
                    <destination-type>javax.jms.Queue</destination-type>
                    <subscription-durability>Durable</subscription-durability>
                 </message-driven-destination>

        The above config doesn't make sense since subscription-durability is only applicable for Topics.

        This resulted in a message that didn't directly point to the problem:

        C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear myplan.xml
            Error: Unable to distribute my.ear: JMS settings for
            message-driven bean FooMDBean are not valid:
            Invalid settings: clientId must be set since durable subscription
            was requested. subscriptionName must be set since durable
            subscription was requested.

                Invalid settings: clientId must be set since durable subscription
            was requested. subscriptionName must be set since durable
            subscription was requested.

        With the patch applied, the error will now be:

        C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear wmyplan.xml
            Error: Unable to distribute my.ear: JMS settings for
            message-driven bean FooMDBean are not valid:
            Invalid settings: subscriptionDurability must be set to: Durable
            when destinationType is set to javax.jms.Queue. clientId must be set
            since durable subscription was requested. subscriptionName must be
            set since durable subscription was requested.

                Invalid settings: subscriptionDurability must be set to: Durable
            when destinationType is set to javax.jms.Queue. clientId must be set
            since durable subscription was requested. subscriptionName must be
            set since durable subscription was requested.
        Assignee John Sisson [ johnrsisson ] Hiram Chirino [ chirino ]
        John Sisson made changes -
        Assignee Hiram Chirino [ chirino ] John Sisson [ johnrsisson ]
        John Sisson made changes -
        Attachment AMQ-705-activemq-3.patch [ 14915 ]
        John Sisson made changes -
        Attachment AMQ-705-incubator-trunk.patch [ 14916 ]
        John Sisson made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        John Sisson made changes -
        Description Found problem when using Geronimo with an incorrectly configured EJB 2.0 MDB that has:

                 <message-driven-destination>
                    <destination-type>javax.jms.Queue</destination-type>
                    <subscription-durability>Durable</subscription-durability>
                 </message-driven-destination>

        The above config doesn't make sense since subscription-durability is only applicable for Topics.

        This resulted in a message that didn't directly point to the problem:

        C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear myplan.xml
            Error: Unable to distribute my.ear: JMS settings for
            message-driven bean FooMDBean are not valid:
            Invalid settings: clientId must be set since durable subscription
            was requested. subscriptionName must be set since durable
            subscription was requested.

                Invalid settings: clientId must be set since durable subscription
            was requested. subscriptionName must be set since durable
            subscription was requested.

        With the patch applied, the error will now be:

        C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear wmyplan.xml
            Error: Unable to distribute my.ear: JMS settings for
            message-driven bean FooMDBean are not valid:
            Invalid settings: subscriptionDurability must be set to: Durable
            when destinationType is set to javax.jms.Queue. clientId must be set
            since durable subscription was requested. subscriptionName must be
            set since durable subscription was requested.

                Invalid settings: subscriptionDurability must be set to: Durable
            when destinationType is set to javax.jms.Queue. clientId must be set
            since durable subscription was requested. subscriptionName must be
            set since durable subscription was requested.
        Found problem when using Geronimo with an incorrectly configured EJB 2.0 MDB that has:

                 <message-driven-destination>
                    <destination-type>javax.jms.Queue</destination-type>
                    <subscription-durability>Durable</subscription-durability>
                 </message-driven-destination>

        The above config doesn't make sense since subscription-durability is only applicable for Topics.

        This resulted in a message that didn't directly point to the problem:

        C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear myplan.xml
            Error: Unable to distribute my.ear: JMS settings for
            message-driven bean FooMDBean are not valid:
            Invalid settings: clientId must be set since durable subscription was requested. subscriptionName must be set since durable subscription was requested.

        With the patch applied, the error will now be:

        C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear wmyplan.xml
            Error: Unable to distribute my.ear: JMS settings for
            message-driven bean FooMDBean are not valid:
            Invalid settings: subscriptionDurability cannot be set to: Durable when destinationType is set to javax.jms.Queue as it is only valid when destinationType is set to javax.jms.Topic. clientId must be set since durable subscription was requested. subscriptionName must be set since durable subscription was requested.

        John Sisson made changes -
        Attachment AMQ-705-activemq-3.patch [ 14917 ]
        John Sisson made changes -
        Attachment AMQ-705-incubator-trunk.patch [ 14918 ]
        John Sisson made changes -
        Assignee John Sisson [ johnrsisson ] Hiram Chirino [ chirino ]
        Hide
        Hiram Chirino added a comment -

        Great patch! Applied!

        Show
        Hiram Chirino added a comment - Great patch! Applied!
        Hiram Chirino made changes -
        Fix Version/s 4.1 [ 11691 ]
        Fix Version/s 4.0 [ 11660 ]
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Jeff Turner made changes -
        Project Import Fri Nov 26 22:32:02 EST 2010 [ 1290828722158 ]

          People

          • Assignee:
            Hiram Chirino
            Reporter:
            John Sisson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development