[AMQ-6635] Wrong message encoding for non-UTF systems

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 5.14.4
• Component/s: STOMP

Environment

system where encoding not set to UTF-8 by default

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Grigory Panov
• Created: 22/Mar/17 08:05
• Updated: 22/Mar/17 08:06

Description

in StompConnection.java

public void send(String destination, String message, String transaction, HashMap<String, String> headers) throws Exception {
        if (headers == null) {
            headers = new HashMap<String, String>();
        }
        headers.put("destination", destination);
        if (transaction != null) {
            headers.put("transaction", transaction);
        }
        StompFrame frame = new StompFrame("SEND", headers, message.getBytes());
        sendFrame(frame.format());
    }

should be

public void send(String destination, String message, String transaction, HashMap<String, String> headers) throws Exception {
        if (headers == null) {
            headers = new HashMap<String, String>();
        }
        headers.put("destination", destination);
        if (transaction != null) {
            headers.put("transaction", transaction);
        }
        StompFrame frame = new StompFrame("SEND", headers, message.getBytes("UTF-8"));
        sendFrame(frame.format());
    }

or, at least if you use default encoding for converting here, you should use default encoding in StompFrame.format()