[AMQ-6290] JMS Pool reconnection logic not always reliable

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.13.0, 5.13.1, 5.13.2, 5.13.3
• Fix Version/s: 5.13.4, 5.14.0
• Component/s: JMS client, Pool
• Assignee: Timothy A. Bish
• Reporter: Timothy A. Bish
• Created: 11/May/16 20:01
• Updated: 11/May/16 20:20
• Resolved: 11/May/16 20:16

Description

The reconnect on exception configuration setting in the JMS pool relies on an exception being thrown from the ExceptionListener to signal a reconnect needed. This can miss an exception thrown from the start method when the initial connection attempt is being made and things like security exceptions trigger connection failure. Even if the exception is given to the listener it happens asynchronously which means the pool will be handling out known broken connection instances until the listener gets around to running the close logic.

For the start method we should also be handling the exception in ConnectionPool and checking for the reconnect on exception flag to indicate a failure has occurred and the Connection should be closed and evicted from the pool.

Issue Links

• relates to: AMQ-5534 Generic JMS connection pool should be able to renew connections after JMSException