[AMQ-6164] queue sendLock prevents concurrent journal updates

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.13.0
• Fix Version/s: 5.14.0
• Component/s: Broker, Message Store
• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 09/Feb/16 12:43
• Updated: 09/Feb/16 12:54
• Resolved: 09/Feb/16 12:53

Description

concurrent producers contend on the queue sendlock rather than on the journal, preventing batching or in the case of jdbc, concurrent writes to the db.

The sendlock protects message order, however order is ultimately determined by the sequence id assigned by the persistence adapter.
The ground work for aligning the cursors with the journal sequence ids was layed in https://issues.apache.org/jira/browse/AMQ-4485 and https://issues.apache.org/jira/browse/AMQ-5266

With the ordering between transacted and non transacted producers overlapping the cursor already respects the journal ordering, the sendLock need no longer protect the journal update.

With parallel journal updates we get the benefit of write batching (sharing an fsync) for multiple producers on a single destination.

Issue Links

• is related to: AMQ-4485 Skipped message dispatch with concurrent transacted sends at cursor memory limit
• is related to: AMQ-5266 Stuck Messages in Single Broker when using JDBC Persistent Store