[AMQ-5996] Durable subscription no updated when reactivated sub changes noLocal value

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.10.2, 5.11.2, 5.12.0
• Fix Version/s: 5.12.1, 5.13.0
• Component/s: Broker
• Assignee: Timothy A. Bish
• Reporter: Timothy A. Bish
• Created: 01/Oct/15 21:26
• Updated: 21/Sep/16 13:36
• Resolved: 03/Oct/15 23:59

Description

When a durable subscription that was offline is reactivated and the selector or noLocal value is changed the subscription is supposed to be removed and re-added as if it was a new subscription. We currently handle the selector part to a certain extent but the DurableSubscription instance that backs the offline durable sub contains a selectorExpression that is not updated so subscription will not apply the new selector value unless the broker was restarted before the reactivation.

We don't as of yet handle the change of noLocal on the subscription due to the fact that prior to v5.12.0 the value was not stored in the persistence layer. Now that we store the noLocal value we can check that along with the selector and update the subscription, which also needs to update the selectorExpression as the noLocal value is filtered via its own expression on the selector chain.

Issue Links

• is related to: AMQ-6430 noLocal=true in durable subscriptions is ignored after reconnect