[AMQ-5865] Enable "getRemoteAddress()" method in WebSocket Requests

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 5.11.0, 5.11.1
• Fix Version/s: 5.12.0
• Component/s: MQTT, STOMP
• Labels: easyfix easytest features javascript patch

Environment

all

• Flags: Important
• Assignee: Timothy A. Bish
• Reporter: Christian Kemper
• Created: 26/Jun/15 05:13
• Updated: 30/Jun/15 05:24
• Resolved: 29/Jun/15 19:41

Description

The method (getRemoteAddress()) in class "org.apache.activemq.transport.ws.AbstractStompSocket" does not return the correct address; it returns always ""StompSocket_" + hashCode();"

We need the correct address (e.g. "wss://127.0.0.1:63114") for our use case.

The implementation whould be very simple.
In class "org.apache.activemq.transport.ws.jetty8.WSServlet" (and also in jetty9 package) pass the address during creation of class StompSocket in the same package:

String scheme = request.getScheme();
if ("http".equalsIgnoreCase(scheme)) {
scheme = "ws";
} else if ("https".equalsIgnoreCase(scheme))

{ scheme = "wss"; }

WebSocket socket = new CustomStompSocket(scheme + "://" + request.getRemoteAddr() + ":" + request.getRemotePort());

It meight be that MQTT is also affected; a fix should be done by the same way.