[AMQ-5859] Reconnection attempt logic seems wrong in JmsConnector#doInitializeConnection

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 5.10.2, 5.11.1
• Fix Version/s: 5.12.0
• Component/s: Broker
• Patch Info: Patch Available
• Flags: Patch
• Assignee: Unassigned
• Reporter: Benoit Wiart
• Created: 23/Jun/15 16:49
• Updated: 29/Nov/16 16:46
• Resolved: 30/Jun/15 17:01

Description

the reconnection attempts logic based on the reconnection policy seems wrong.

In JmsConnector#doInitializeConnection the loop trying to reconnect to the foreign broker only execute once due to the erroneous test in the while

while (maxRetries < ++attempt && !connectionSerivce.isTerminating());

should be

while (maxRetries > ++attempt && !connectionSerivce.isTerminating());

Issue Links

• links to: GitHub Pull Request #122