Uploaded image for project: 'ActiveMQ'
  1. ActiveMQ
  2. AMQ-5263

Method ActiveMQSession.close() is not thread safe as declared and required

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 5.9.1
    • Fix Version/s: None
    • Component/s: JMS client
    • Labels:
      None
    • Environment:

      any operationg system, and any platform

      Description

      If ActiveMQSession.close() and ActiveMQSession.dispose() run concurrently, the statements in close() method might throw NullPointerException。Just marked by the following code snippet.
      -------------------------------
      public void ActiveMQSession.close() throws JMSException {
      if (!closed) {
      if (getTransactionContext().isInXATransaction()) { // it might throw NullPointerException
      ...
      -------------------------------
      In my application, I call Session.close() when I detect JMSException, but Session.close() throws NullPointerException occasionally。I suspect that's because ActiveMQConnection called ActiveMQSession.dispose() in case of transport error, and ActiveMQSession.dispose() nullified ActiveMQSession.transactionContext before ActiveMQSession.closed is assigned to false. Since this NullPointerException error just happened once and can not be reproduced, it's only a suspection.

      It seems that close() and dispose() should be synchronized, and then sessions can be closed safely.

      I'm not good at English, but I hope this issue is demonstrated clearly enough.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jiangfuqiang Jiang Fuqiang
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: