[AMQ-5263] Method ActiveMQSession.close() is not thread safe as declared and required

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 5.9.1
• Component/s: JMS client

Environment

any operationg system, and any platform

• Assignee: Unassigned
• Reporter: Jiang Fuqiang
• Created: 08/Jul/14 07:18
• Updated: 12/Sep/18 14:35

Description

If ActiveMQSession.close() and ActiveMQSession.dispose() run concurrently, the statements in close() method might throw NullPointerException。Just marked by the following code snippet.
-------------------------------
public void ActiveMQSession.close() throws JMSException {
if (!closed) {
if (getTransactionContext().isInXATransaction()) { // it might throw NullPointerException
...
-------------------------------
In my application, I call Session.close() when I detect JMSException, but Session.close() throws NullPointerException occasionally。I suspect that's because ActiveMQConnection called ActiveMQSession.dispose() in case of transport error, and ActiveMQSession.dispose() nullified ActiveMQSession.transactionContext before ActiveMQSession.closed is assigned to false. Since this NullPointerException error just happened once and can not be reproduced, it's only a suspection.

It seems that close() and dispose() should be synchronized, and then sessions can be closed safely.

I'm not good at English, but I hope this issue is demonstrated clearly enough.