Uploaded image for project: 'ActiveMQ'
  1. ActiveMQ
  2. AMQ-5028

Remove jetty and jsp compiler jars from web-console.war

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.9.1, 5.10.0
    • Component/s: Web Console
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The container that runs the war (like Jetty or Tomcat) will compile the JSP's so there is no need for the eclipse core compiler. Also, there isn't a need for the jetty jars. It looks like there was an attempt to exclude those from packaging anyway via maven-war-plugin configs, but those configs aren't working.

      patch:

      diff --git a/activemq-web-console/pom.xml b/activemq-web-console/pom.xml
      index e5f2e94..93b7fad 100755
      --- a/activemq-web-console/pom.xml
      <?xml version="1.0" encoding="UTF-8"?>
      <!--
      +++ b/activemq-web-console/pom.xml
      @@ -190,6 +190,14 @@
                     <groupId>${project.groupId}</groupId>
                     <artifactId>activemq-all</artifactId>
                 </exclusion>
      +          <exclusion>
      +              <groupId>org.eclipse.jetty</groupId>
      +              <artifactId>jetty-websocket</artifactId>
      +          </exclusion>
      +          <exclusion>
      +              <groupId>org.eclipse.jetty</groupId>
      +              <artifactId>jetty-continuation</artifactId>
      +          </exclusion>
             </exclusions>
           </dependency>
           <dependency>
      @@ -235,6 +243,7 @@
             <groupId>org.eclipse.jdt</groupId>
             <artifactId>core</artifactId>
             <version>3.1.1</version>
      +      <scope>test</scope>
           </dependency>
           <dependency>
             <groupId>org.slf4j</groupId>
      @@ -259,16 +268,6 @@
             <artifactId>standard</artifactId>
           </dependency>
       
      -    <!-- XStream marshalling -->
      -    <dependency>
      -      <groupId>xpp3</groupId>
      -      <artifactId>xpp3</artifactId>
      -    </dependency>
      -    <dependency>
      -      <groupId>com.thoughtworks.xstream</groupId>
      -      <artifactId>xstream</artifactId>
      -    </dependency>
      -
           <!-- used for testing -->
           <dependency>
             <groupId>junit</groupId>
      
      

        Attachments

          Activity

            People

            • Assignee:
              dkulp Daniel Kulp
              Reporter:
              dkulp Daniel Kulp
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: