[AMQ-4814] Memory leak when unsubscribing durable consumer

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.8.0
• Fix Version/s: 5.12.0
• Component/s: Broker
• Labels: broker durable_subscription memory_leak
• Patch Info: Patch Available
• Assignee: Timothy A. Bish
• Reporter: jok
• Created: 18/Oct/13 08:17
• Updated: 06/Jul/15 22:21
• Resolved: 06/Jul/15 22:21

Description

When creating and closing durable subscribers, references to FilePendingMessageCursor in MemoryUsage.listeners are not cleaned up.

The reason seems to be a missing call to FilePendingMessageCursor.destroy() in StoreDurableSubscriberCursor.stop().

A simple demo to reproduce the issue is attached (the leak is clearly visible after a few hundred to thousand runs). Also, i have attached a patch which resolves this issue for me - could someone check if this is correct?