[AMQ-4433] Socket parameters are not validated

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.9.1, 5.10.0
• Component/s: Transport
• Patch Info: Patch Available
• Assignee: Claus Ibsen
• Reporter: Christoffer Sawicki
• Created: 03/Apr/13 11:15
• Updated: 03/Apr/14 00:01
• Resolved: 31/Oct/13 11:13

Description

Connect parameters are validated in every transport factory with a statement like this:

if (!options.isEmpty()) {
  throw new IllegalArgumentException("Invalid connect parameters: " + options);
}

Socket parameters (i.e. connect parameters prefixed with socket.) are however never validated.

They are put away at

TcpTransportFactory.compositeConfigure(Transport, WireFormat, Map) line: 85	

and then set at

TcpTransport.initialiseSocket(Socket) line: 428

where there is no check that socketOptions is empty after the call.

I've attached a patch (#1) that rectifies this.

Bonus: I found similar issues in the transport classes. See patch #2 and #3.

Issue Links

• is related to: AMQ-4582 Specifying invalid ciphersuite in SSL transport causes all available ciphersuites to be enabled